Github user jose-torres commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20933#discussion_r178235158
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
 ---
    @@ -213,6 +215,26 @@ case class DataSourceAnalysis(conf: SQLConf) extends 
Rule[LogicalPlan] with Cast
       }
     }
     
    +/**
    + * Replaces [[OrcDataSourceV2]] with [[DataSource]] if parent node is 
[[InsertIntoTable]].
    + * This is because [[OrcDataSourceV2]] doesn't support writing data yet.
    --- End diff --
    
    Shouldn't Spark handle this already when it sees that OrcDataSourceV2 
doesn't implement WriteSupport?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to