Github user chenghao-intel commented on the pull request:

    https://github.com/apache/spark/pull/2762#issuecomment-60541840
  
    @marmbrus @gvramana , #2802 looks good to me in general to fix the constant 
value pass into the Hive UDFs, and it does some overlap work with this PR.  The 
reason I prefer taking the ObjectInspector as parameter are:
    * java.util.List[Object], Array[Object] can works with both 
`StructObjectInspector`, the same for `ListObjectInspector`, without parameter 
`ObjectInspector`, the methods "unwrap / wrap" is probably ambiguous. 
    * ObjectInspector takes information other than "Constant", for example the 
method ".preferWritable", which is a hint for trivial optimization in unwrap.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to