Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20935#discussion_r178444026
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala
 ---
    @@ -307,7 +308,7 @@ private[columnar] final class 
DecimalColumnStats(precision: Int, scale: Int) ext
           // TODO: this is not right for DecimalType with precision > 18
           gatherValueStats(value)
         } else {
    -      gatherNullStats
    +      gatherNullStats()
    --- End diff --
    
    I don't think the change to `gatherNullStats` is necessary...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to