Github user foxish commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20943#discussion_r178609700
  
    --- Diff: 
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/steps/BasicDriverConfigurationStepSuite.scala
 ---
    @@ -91,7 +91,7 @@ class BasicDriverConfigurationStepSuite extends 
SparkFunSuite {
         val resourceRequirements = 
preparedDriverSpec.driverContainer.getResources
         val requests = resourceRequirements.getRequests.asScala
         assert(requests("cpu").getAmount === "2")
    -    assert(requests("memory").getAmount === "256Mi")
    +    assert(requests("memory").getAmount === "456Mi")
    --- End diff --
    
    I'm wondering - shouldn't this be 256M + 384M?
    The documentation says - `executorMemory * 0.10, with minimum of 384`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to