Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19082#discussion_r178716133
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
 ---
    @@ -825,52 +924,92 @@ case class HashAggregateExec(
         ctx.currentVars = new 
Array[ExprCode](aggregateBufferAttributes.length) ++ input
     
         val updateRowInRegularHashMap: String = {
    -      ctx.INPUT_ROW = unsafeRowBuffer
    +      // We need to copy the aggregation row buffer to a local row first 
because each aggregate
    +      // function directly updates the buffer when it finishes.
    --- End diff --
    
    We need this copy because: 
https://github.com/apache/spark/pull/19082#discussion_r143326742


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to