Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r179335313
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java
---
@@ -515,7 +518,8 @@ public void writeToOutputStreamUnderflow() throws
IOException {
final byte[] test = "01234567".getBytes(StandardCharsets.UTF_8);
for (int i = 1; i <= Platform.BYTE_ARRAY_OFFSET; ++i) {
- UTF8String.fromAddress(test, Platform.BYTE_ARRAY_OFFSET - i,
test.length + i)
+ new UTF8String(
+ new ByteArrayMemoryBlock(test, Platform.BYTE_ARRAY_OFFSET - i,
test.length + i))
--- End diff --
Sure, I just say it looks strange. I know you didn't change the unit test's
behavior.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
