Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2957#issuecomment-60574364
@zsxwing You're trying to handle the case where `thread` changes between
checking `thread != null` and calling `thread.interrupt()` right? Copying
`thread` to a local variable is a simple way to address that. The call to
`cancel()` may view `thread` before or after the `finally` block makes it
`null` but that's fine either way.
Is there a different race condition you're trying to solve? you can't call
`run()` from multiple threads here, but this change wouldn't change that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
