Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20965#discussion_r179448598
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -254,6 +256,80 @@ case class HashAggregateExec(
""".stripMargin
}
+ // Extracts all the input variable references for a given `aggExpr`.
This result will be used
+ // to split aggregation into small functions.
+ private def getInputVariableReferences(
--- End diff --
hopefully this method will become easier after @viirya's PR gets merged.
Anyway, this seems to me quite a generic method: shall we move it to
`CodeGenerator`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
