Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20937#discussion_r179506801
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/CreateJacksonParser.scala
 ---
    @@ -39,11 +40,36 @@ private[sql] object CreateJacksonParser extends 
Serializable {
         jsonFactory.createParser(new InputStreamReader(bain, "UTF-8"))
       }
     
    -  def text(jsonFactory: JsonFactory, record: Text): JsonParser = {
    -    jsonFactory.createParser(record.getBytes, 0, record.getLength)
    +  def text(jsonFactory: JsonFactory, record: Text, encoding: 
Option[String] = None): JsonParser = {
    +    encoding match {
    --- End diff --
    
    https://github.com/apache/spark/pull/20937#discussion_r178476075 seems 
missed and other hidden comments too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to