Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20933#discussion_r179521502
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -213,6 +215,26 @@ case class DataSourceAnalysis(conf: SQLConf) extends
Rule[LogicalPlan] with Cast
}
}
+/**
+ * Replaces [[OrcDataSourceV2]] with [[DataSource]] if parent node is
[[InsertIntoTable]].
+ * This is because [[OrcDataSourceV2]] doesn't support writing data yet.
--- End diff --
I agree with @jose-torres. If there is a general problem when writes aren't
supported, then shouldn't this be a generic rule that provides a good error
message?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
