Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20986#discussion_r179645207
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -176,6 +141,23 @@ object GenerateUnsafeProjection extends
CodeGenerator[Seq[Expression], UnsafePro
""".trim
}
+
+ private def writeArrayToBuffer(
--- End diff --
It's weird to have 2 `writeArrayToBuffer`. Since this one is only called in
one place, can we inline it?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
