Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20962#discussion_r179664682
--- Diff: python/pyspark/sql/column.py ---
@@ -450,21 +450,69 @@ def isin(self, *cols):
Returns a sort expression based on the ascending order of the given
column name
>>> from pyspark.sql import Row
- >>> df = spark.createDataFrame([Row(name=u'Tom', height=80),
Row(name=u'Alice', height=None)])
+ >>> df = spark.createDataFrame([('Tom', 80), ('Alice', None)],
["name", "height"])
>>> df.select(df.name).orderBy(df.name.asc()).collect()
[Row(name=u'Alice'), Row(name=u'Tom')]
"""
+ _asc_nulls_first_doc = """
+ Returns a sort expression based on the ascending order of the given
column name and null values
--- End diff --
very small nit: shall we exactly match the doc with Scala side?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
