Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20933#discussion_r179676507
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -368,8 +368,7 @@ case class FileSourceScanExec(
val bucketed =
selectedPartitions.flatMap { p =>
p.files.map { f =>
- val hosts = getBlockHosts(getBlockLocations(f), 0, f.getLen)
--- End diff --
moving code need a reason. The reason here is to help us to reuse the code.
But if we do it in another PR, what is the reason? It doesn't make the code
more clear IMO.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]