Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20987#discussion_r179776800
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -494,19 +507,6 @@ private[spark] class Executor(
               setTaskFinishedAndClearInterruptStatus()
               execBackend.statusUpdate(taskId, TaskState.FAILED, 
ser.serialize(reason))
     
    -        case t: TaskKilledException =>
    -          logInfo(s"Executor killed $taskName (TID $taskId), reason: 
${t.reason}")
    -          setTaskFinishedAndClearInterruptStatus()
    -          execBackend.statusUpdate(taskId, TaskState.KILLED, 
ser.serialize(TaskKilled(t.reason)))
    -
    -        case _: InterruptedException | NonFatal(_) if
    -            task != null && task.reasonIfKilled.isDefined =>
    -          val killReason = task.reasonIfKilled.getOrElse("unknown reason")
    -          logInfo(s"Executor interrupted and killed $taskName (TID 
$taskId), reason: $killReason")
    -          setTaskFinishedAndClearInterruptStatus()
    -          execBackend.statusUpdate(
    -            taskId, TaskState.KILLED, 
ser.serialize(TaskKilled(killReason)))
    -
             case CausedBy(cDE: CommitDeniedException) =>
    --- End diff --
    
    I shoudl have caught it too :)  Kay mentioned OOM handling on the original 
pr, but we didn't think about interrupts.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to