Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20828#discussion_r179818854
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousMemoryStream.scala
---
@@ -0,0 +1,212 @@
+/*
--- End diff --
I think the consistent naming makes sense for the sources where they're
automatically injected in planning, since they both have the same .format()
option and thus the same name in some sense.
For memory streams it's different; the user explicitly instantiates the
reader. So I think that making the names look similar is confusing, and I don't
think that "MemoryStreamMicroBatchReader" is a good name for something
explicitly instantiated.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
