Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20987#discussion_r179931481
--- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
---
@@ -257,19 +281,32 @@ class ExecutorSuite extends SparkFunSuite with
LocalSparkContext with MockitoSug
}
private def runTaskAndGetFailReason(taskDescription: TaskDescription):
TaskFailedReason = {
- runTaskGetFailReasonAndExceptionHandler(taskDescription)._1
+ runTaskGetFailReasonAndExceptionHandler(taskDescription, false)._1
}
private def runTaskGetFailReasonAndExceptionHandler(
- taskDescription: TaskDescription): (TaskFailedReason,
UncaughtExceptionHandler) = {
+ taskDescription: TaskDescription,
+ killTask: Boolean): (TaskFailedReason, UncaughtExceptionHandler) = {
val mockBackend = mock[ExecutorBackend]
val mockUncaughtExceptionHandler = mock[UncaughtExceptionHandler]
var executor: Executor = null
+ var killingThread: Thread = null
--- End diff --
yeah good point -- I was originally thinking of that but I don't think that
is needed. however I did get rid of the indefinite awaits.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
