Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19691#discussion_r179940633
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
 ---
    @@ -282,6 +282,27 @@ class AstBuilder(conf: SQLConf) extends 
SqlBaseBaseVisitor[AnyRef] with Logging
         parts.toMap
       }
     
    +  /**
    +   * Create a partition filter specification.
    +   */
    +  def visitPartitionFilterSpec(ctx: PartitionSpecContext): Expression = 
withOrigin(ctx) {
    +    val parts = ctx.expression.asScala.map { pVal =>
    +      expression(pVal) match {
    +        case EqualNullSafe(_, _) =>
    +          throw new ParseException("'<=>' operator is not allowed in 
partition specification.", ctx)
    +        case cmp @ BinaryComparison(UnresolvedAttribute(name :: Nil), 
constant: Literal) =>
    +          cmp.withNewChildren(Seq(AttributeReference(name, StringType)(), 
constant))
    +        case _ =>
    +          throw new ParseException("Invalid partition filter 
specification", ctx)
    +      }
    +    }
    +    if(parts.isEmpty) {
    --- End diff --
    
    wouldn't be better to return the `Seq[Expression]` as it is? Later we need 
it like that (in `listPartitionsByFilter `) and in this way we can avoid using 
`null` which is a good thing too...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to