Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21001#discussion_r180191279
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
 ---
    @@ -167,15 +167,6 @@ abstract class ExternalCatalogSuite extends 
SparkFunSuite with BeforeAndAfterEac
         assert(actual.tableType === CatalogTableType.EXTERNAL)
       }
     
    -  test("create table when the table already exists") {
    --- End diff --
    
    We check table existence in `SessionCatalog` instead of `ExternalCatalog` 
now. 
    `SessionCatalogSuite` has similar test case, so no need to create new one.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to