Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21021#discussion_r180310842
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
    @@ -324,6 +324,30 @@ class DataFrameFunctionsSuite extends QueryTest with 
SharedSQLContext {
         assert(intercept[AnalysisException] {
           df3.selectExpr("sort_array(a)").collect()
         }.getMessage().contains("only supports array input"))
    +
    +    checkAnswer(
    +      df.select(array_sort($"a"), array_sort($"b")),
    +      Seq(
    +        Row(Seq(1, 2, 3), Seq("a", "b", "c")),
    +        Row(Seq[Int](), Seq[String]()),
    +        Row(null, null))
    +    )
    +    checkAnswer(
    +      df.selectExpr("array_sort(a)", "array_sort(b)"),
    +      Seq(
    +        Row(Seq(1, 2, 3), Seq("a", "b", "c")),
    +        Row(Seq[Int](), Seq[String]()),
    --- End diff --
    
    Maybe `Seq.empty[Int]`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to