Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21010#discussion_r180312702
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -2108,35 +2132,52 @@ case class FormatNumber(x: Expression, d:
Expression)
// SPARK-13515: US Locale configures the DecimalFormat object to use
a dot ('.')
// as a decimal separator.
val usLocale = "US"
- val i = ctx.freshName("i")
val dFormat = ctx.freshName("dFormat")
--- End diff --
`dFormat` is not used in any place. We can remove it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
