Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21020#discussion_r180312977
  
    --- Diff: docs/README.md ---
    @@ -22,10 +22,13 @@ $ sudo gem install jekyll jekyll-redirect-from 
pygments.rb
     $ sudo pip install Pygments
     # Following is needed only for generating API docs
     $ sudo pip install sphinx pypandoc mkdocs
    -$ sudo Rscript -e 'install.packages(c("knitr", "devtools", "roxygen2", 
"testthat", "rmarkdown"), repos="http://cran.stat.ucla.edu/";)'
    +$ sudo Rscript -e 'install.packages(c("knitr", "devtools", "testthat", 
"rmarkdown"), repos="http://cran.stat.ucla.edu/";)'
    +$ sudo Rscript -e 'devtools::install_version("roxygen2", version = 
"5.0.1", repos="http://cran.stat.ucla.edu/";)'
     ```
     
    -(Note: If you are on a system with both Ruby 1.9 and Ruby 2.0 you may need 
to replace gem with gem2.0)
    +Note: If you are on a system with both Ruby 1.9 and Ruby 2.0 you may need 
to replace gem with gem2.0.
    +
    +Note: Other versions of roxygen2 might work in SparkR documentation 
generation but `RoxygenNote` field in `SPARK_HOME/R/pkg/DESCRIPTION` is 5.0.1, 
which is updated if the version is mismatched.
    --- End diff --
    
    nit `$SPARK_HOME/R/pkg/DESCRIPTION`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to