Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21007#discussion_r180584581
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/TestQueryExecutionListener.scala 
---
    @@ -0,0 +1,45 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql
    +
    +import java.util.concurrent.atomic.AtomicBoolean
    +
    +import org.apache.spark.internal.Logging
    +import org.apache.spark.sql.execution.QueryExecution
    +import org.apache.spark.sql.util.QueryExecutionListener
    +
    +
    +class TestQueryExecutionListener extends QueryExecutionListener with 
Logging {
    +  override def onSuccess(funcName: String, qe: QueryExecution, durationNs: 
Long): Unit = {
    +    OnSuccessCall.isOnSuccessCalled.set(true)
    +  }
    +
    +  override def onFailure(funcName: String, qe: QueryExecution, exception: 
Exception): Unit = { }
    +}
    +
    +/**
    + * This has a variable to check if `onSuccess` is actually called or not. 
Currently, this is for
    + * the test case in PySpark. See SPARK-23942.
    + */
    +object OnSuccessCall {
    +  val isOnSuccessCalled = new AtomicBoolean(false)
    +
    +  def isCalled(): Boolean = isOnSuccessCalled.get()
    +
    +  def clear(): Unit = isOnSuccessCalled.set(false)
    +}
    --- End diff --
    
    does this need a newline at the end?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to