Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20998#discussion_r180784912
  
    --- Diff: 
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
    @@ -880,8 +880,8 @@ class TaskSetManagerSuite extends SparkFunSuite with 
LocalSparkContext with Logg
         assert(manager.resourceOffer("execB", "host2", ANY).get.index === 3)
       }
     
    -  test("speculative task should not run on a given host where another 
attempt " +
    -    "is already running on") {
    +  test("SPARK-23888: speculative task should not run on a given host " +
    +    "where another attempt is already running on") {
    --- End diff --
    
    I'd reword this to be a bit more specific to what you're trying to test: 
    
    speculative task cannot run on host with another running attempt, but can 
run on a host with a failed attempt.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to