Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21024#discussion_r181085033
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -287,3 +287,68 @@ case class ArrayContains(left: Expression, right:
Expression)
override def prettyName: String = "array_contains"
}
+
+
+/**
+ * Returns the maximum value in the array.
+ */
+@ExpressionDescription(
+ usage = "_FUNC_(array) - Returns the maximum value in the array.",
+ examples = """
+ Examples:
+ > SELECT _FUNC_(array(1, 20, null, 3));
+ 20
+ """, since = "2.4.0")
+case class ArrayMax(child: Expression) extends UnaryExpression with
ImplicitCastInputTypes {
+
+ override def nullable: Boolean =
+ child.nullable || child.dataType.asInstanceOf[ArrayType].containsNull
--- End diff --
This should always be `true` because the array might be empty?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
