Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21031#discussion_r181652753
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
 ---
    @@ -407,6 +407,7 @@ object FunctionRegistry {
         expression[MapKeys]("map_keys"),
         expression[MapValues]("map_values"),
         expression[Size]("size"),
    +    expression[Cardinality]("cardinality"),
    --- End diff --
    
    In Presto, `cardinality`'s return type is `BigInt`. Thus, `cardinality` in 
Spark uses uses `long` as return type. If we use `int` as `cardinality`'s 
return type, I think that it works.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to