Github user ala commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20888#discussion_r181764082
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala ---
    @@ -152,39 +154,54 @@ class DataFrameRangeSuite extends QueryTest with 
SharedSQLContext with Eventuall
       }
     
       test("Cancelling stage in a query with Range.") {
    -    val listener = new SparkListener {
    -      override def onJobStart(jobStart: SparkListenerJobStart): Unit = {
    -        eventually(timeout(10.seconds), interval(1.millis)) {
    -          assert(DataFrameRangeSuite.stageToKill > 0)
    +    val slices = 10
    +
    +    // Save and restore the value because SparkContext is shared
    +    val savedInterruptOnCancel = sparkContext
    +      .getLocalProperty(SparkContext.SPARK_JOB_INTERRUPT_ON_CANCEL)
    +
    +    try {
    +      
sparkContext.setLocalProperty(SparkContext.SPARK_JOB_INTERRUPT_ON_CANCEL, 
"true")
    +
    +      for (codegen <- Seq(true, false)) {
    +        val latch = new CountDownLatch(2)
    --- End diff --
    
    Could you add a comment explaining what is the purpose of the latch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to