Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21037#discussion_r181827177
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
 ---
    @@ -287,3 +287,61 @@ case class ArrayContains(left: Expression, right: 
Expression)
     
       override def prettyName: String = "array_contains"
     }
    +
    +/**
    + * A function that returns the position of the first occurrence of element 
in the given array
    + * as long. Returns 0 if substr could not be found in str.
    + * Returns null if either of the arguments are null and
    + *
    + * NOTE: that this is not zero based, but 1-based index. The first 
character in str has index 1.
    + */
    +@ExpressionDescription(
    +  usage = """
    +    _FUNC_(array, element) - Returns the (1-based) index of the first 
element of the array as long.
    +  """,
    +  examples = """
    +    Examples:
    +      > SELECT _FUNC_(array(3, 2, 1), 1);
    +       3
    +  """,
    +  since = "2.4.0")
    +case class ArrayPosition(left: Expression, right: Expression)
    --- End diff --
    
    According to [these UTs in 
Presto](https://github.com/prestodb/presto/blob/master/presto-main/src/test/java/com/facebook/presto/type/TestArrayOperators.java#L651-L656),
 you are right.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to