Github user henryr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21072#discussion_r181849951
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantSortsSuite.scala
 ---
    @@ -98,4 +98,31 @@ class RemoveRedundantSortsSuite extends PlanTest {
         val correctAnswer = groupedAndResorted.analyze
         comparePlans(optimized, correctAnswer)
       }
    +
    --- End diff --
    
    Could you add a test which explicitly confirms that sort.limit.sort is not 
simplified? I know the above two tests cover that case, but it's good to have 
one dedicated to testing this important property. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to