Github user devaraj-kavali commented on the issue:
https://github.com/apache/spark/pull/21071
Thanks @steveloughran and @rdblue for looking into this.
bq. this turns HTrace on always; do you think it should be optional
It operates on NullScope which doesn't do anything when there are no
SpanReceivers and Samplers configured, I think it would be ok or otherwise we
can add a configuration to enable or disable.
bq. needs some tests to handle malformed span-ids coming in?
sure, I will add more tests to handle these scenarios.
@rdblue,
I understand it should be optimal, I verified with the few tests and don't
see any measurable impact with these changes. I can measure the performance
with more tests and post if we all agree on this approach.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
