Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21019#discussion_r181889300
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -1433,6 +1426,16 @@ class DAGScheduler(
         }
       }
     
    +  private[scheduler] def markMapStageJobsAsFinished(shuffleStage: 
ShuffleMapStage): Unit = {
    +    // Mark any map-stage jobs waiting on this stage as finished
    +    if (shuffleStage.isAvailable && shuffleStage.mapStageJobs.nonEmpty) {
    --- End diff --
    
    doesn't seem this is necessary, as its already handled at the callsites ... 
but IMO its seems safer to include it, in case this gets invoked elsewhere in 
the future.  


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to