Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2530#issuecomment-60716747
This LGTM.
One question related to this - should we use abstract class instead of
trait? It would be better for maintaining binary compatibility across versions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
