Github user jkbradley commented on the issue:

    https://github.com/apache/spark/pull/21090
  
    **To review this PR**: This was copied from 
https://github.com/apache/spark/pull/15770 with the following changes:
    * Addressed comments in original PR  (See my review comments there)
    * Added Param validators for required input columns
    * Renamed “weights” column to “similarities”
    * Made algorithm take more types of inputs: Long/Int and Double/Float
    * Removed test("set parameters") since setters are already tested in the 
read/write test.
    
    If you saw the previous PR, you should be able to review this one based on 
the last 3 commits, viewable in this diff: 
https://github.com/jkbradley/spark/compare/5cb8ed6...wangmiao1981-pic


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to