Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21008#discussion_r182625943
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -870,24 +870,14 @@ object DateTimeUtils {
* If time1 and time2 having the same day of month, or both are the last
day of month,
* it returns an integer (time under a day will be ignored).
*
- * Otherwise, the difference is calculated based on 31 days per month,
and rounding to
- * 8 digits.
+ * Otherwise, the difference is calculated based on 31 days per month.
+ * If `roundOff` is set to true, the result is rounded to 8 decimal
places.
*/
- def monthsBetween(time1: SQLTimestamp, time2: SQLTimestamp): Double = {
--- End diff --
Can we remove this?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
