GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/21107

    [DO-NOT-MERGE][WIP] Explicitly print out skipped tests from unittest module

    ## What changes were proposed in this pull request?
    
    This PR proposes to remove duplicated dependency checking logics and also 
print out skipped tests from unittests modules. 
    
    For example, as below:
    
    ```
    Skipped tests in pyspark.sql.tests with pypy:
        test_createDataFrame_column_name_encoding 
(pyspark.sql.tests.ArrowTests) ... skipped 'Pandas >= 0.19.2 must be installed; 
however, it was not found.'
        test_createDataFrame_does_not_modify_input 
(pyspark.sql.tests.ArrowTests) ... skipped 'Pandas >= 0.19.2 must be installed; 
however, it was not found.'
        test_createDataFrame_fallback_disabled (pyspark.sql.tests.ArrowTests) 
... skipped 'Pandas >= 0.19.2 must be installed; however, it was not found.'
    ...
    
    Skipped tests in pyspark.sql.tests with python3:
        test_createDataFrame_column_name_encoding 
(pyspark.sql.tests.ArrowTests) ... skipped 'PyArrow >= 0.8.0 must be installed; 
however, it was not found.'
        test_createDataFrame_does_not_modify_input 
(pyspark.sql.tests.ArrowTests) ... skipped 'PyArrow >= 0.8.0 must be installed; 
however, it was not found.'
    ...
    ```
    
    Currently, it's not printed out in the console. I think we should better 
print out skipped tests in the console.
    
    This is currently WIP. I tested partially in my local. It needs a Jenkins 
build and we need to see if the error messages actually look okay.
    
    ## How was this patch tested?
    
    Manually tested. Also, fortunately, Jenkins has good environment to test 
the skipped output.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark skipped-tests-print

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21107
    
----
commit ccba1c182174d065c76f7f544989aa81c8f8c941
Author: hyukjinkwon <gurwls223@...>
Date:   2018-04-19T14:57:33Z

    Explicitly print out skipped tests from unittest module

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to