Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2744#discussion_r19472179
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
    @@ -330,12 +331,21 @@ private[yarn] abstract class YarnAllocator(
               logInfo("Completed container %s (state: %s, exit status: 
%s)".format(
                 containerId,
                 completedContainer.getState,
    -            completedContainer.getExitStatus()))
    +            completedContainer.getExitStatus))
               // Hadoop 2.2.X added a ContainerExitStatus we should switch to 
use
               // there are some exit status' we shouldn't necessarily count 
against us, but for
               // now I think its ok as none of the containers are expected to 
exit
    -          if (completedContainer.getExitStatus() != 0) {
    -            logInfo("Container marked as failed: " + containerId)
    +          if (completedContainer.getExitStatus == -103) { // vmem limit 
exceeded
    +            logWarning(MemLimitLogger.memLimitExceededLogMessage(
    +              completedContainer.getDiagnostics,
    +              MemLimitLogger.VMEM_EXCEEDED_PATTERN))
    +          } else if (completedContainer.getExitStatus == -104) { // pmem 
limit exceeded
    +            logWarning(MemLimitLogger.memLimitExceededLogMessage(
    +              completedContainer.getDiagnostics,
    +              MemLimitLogger.PMEM_EXCEEDED_PATTERN))
    +          } else if (completedContainer.getExitStatus != 0) {
    +            logInfo("Container marked as failed: " + containerId + ". Exit 
status: " +
    --- End diff --
    
    Any reason we don't print the diagnostics message here also?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to