Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/21081#discussion_r182925299 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -305,15 +344,45 @@ class KMeans @Since("1.5.0") ( @Since("1.5.0") def setSeed(value: Long): this.type = set(seed, value) + @Since("2.4.0") + def featureToVector(dataset: Dataset[_], col: Column): Column = { --- End diff -- Is this a copy of the same method? It should be shared, either in KMeansParams or in a static (object) method.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org