Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21110#discussion_r182932853
  
    --- Diff: 
common/network-common/src/main/java/org/apache/spark/network/server/TransportServer.java
 ---
    @@ -98,7 +99,8 @@ private void init(String hostToBind, int portToBind) {
           .group(bossGroup, workerGroup)
           .channel(NettyUtils.getServerChannelClass(ioMode))
           .option(ChannelOption.ALLOCATOR, allocator)
    -      .childOption(ChannelOption.ALLOCATOR, allocator);
    +      .childOption(ChannelOption.ALLOCATOR, allocator)
    +      .childOption(ChannelOption.SO_REUSEADDR, !SystemUtils.IS_OS_WINDOWS);
    --- End diff --
    
    Where would you put it? Every place where this is set? Not a fan of that.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to