Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21052#discussion_r183190383
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala ---
    @@ -382,4 +382,34 @@ class StatisticsCollectionSuite extends 
StatisticsCollectionTestBase with Shared
           }
         }
       }
    +
    +  test("Simple queries must be working, if CBO is turned on") {
    +    withSQLConf(("spark.sql.cbo.enabled", "true")) {
    +      withTable("TBL1", "TBL") {
    +        import org.apache.spark.sql.functions._
    +        val df = spark.range(1000L).select('id,
    +          'id * 2 as "FLD1",
    +          'id * 12 as "FLD2",
    +          lit("aaa") + 'id as "fld3")
    +        df.write
    +          .mode(SaveMode.Overwrite)
    +          .bucketBy(10, "id", "FLD1", "FLD2")
    +          .sortBy("id", "FLD1", "FLD2")
    +          .saveAsTable("TBL")
    +        spark.sql("ANALYZE TABLE TBL COMPUTE STATISTICS ")
    --- End diff --
    
    nit: you don't need the `spark.` prefix


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to