Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20937#discussion_r183270773
  
    --- Diff: python/pyspark/sql/readwriter.py ---
    @@ -773,6 +776,8 @@ def json(self, path, mode=None, compression=None, 
dateFormat=None, timestampForm
                                     formats follow the formats at 
``java.text.SimpleDateFormat``.
                                     This applies to timestamp type. If None is 
set, it uses the
                                     default value, 
``yyyy-MM-dd'T'HH:mm:ss.SSSXXX``.
    +        :param encoding: specifies encoding (charset) of saved json files. 
If None is set,
    +                        the default UTF-8 charset will be used.
    --- End diff --
    
    shall we mention that, if `encoding` is set, `lineSep` also need to be set 
when `multiLine` is false?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to