Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2711#discussion_r19491555
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/CommandUtils.scala ---
@@ -38,6 +40,31 @@ object CommandUtils extends Logging {
command.arguments
}
+ def buildLocalCommand(
--- End diff --
Actually, should this just replace `buildCommandSeq`? I think it makes
little sense to have both `buildLocalCommand` and that. It's really confusing
which one you should use. I would just move everything from `buildCommandSeq`
into here, then make `buildJavaOpts` private.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
