Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2711#discussion_r19492867
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
    @@ -393,6 +396,8 @@ private[spark] trait ClientBase extends Logging {
         // TODO: it would be nicer to just make sure there are no null 
commands here
         val printableCommands = commands.map(s => if (s == null) "null" else 
s).toList
         amContainer.setCommands(printableCommands)
    +    amContainer.setLocalResources(localResources)
    +    amContainer.setEnvironment(launchEnv)
    --- End diff --
    
    Any reason to move these here? I'm fine with keeping these here but I'm 
just curious if this is functionally different in any way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to