Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/2607#issuecomment-60812919
@manishamde Added comments based on a quick pass looking mainly at the
API. My main concern is the same as in my comment above about the verbosity of
(a) the many GradientBoosting.train* methods and (b) BoostingStrategy. Could
you please respond to the comment above about making these more modular for
easier construction? Thanks! In the meantime, I'll make a more detailed pass
over the internals.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
