Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21137#discussion_r183652913
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1267,12 +1274,12 @@ case class ExternalMapToCatalyst private(
val entry = iter.next()
val (key, value) = (entry.getKey, entry.getValue)
keys(i) = if (key != null) {
- keyConverter.eval(InternalRow.fromSeq(key :: Nil))
+ keyConverter.eval(rowWrapper(key))
} else {
throw new RuntimeException("Cannot use null as map key!")
}
values(i) = if (value != null) {
- valueConverter.eval(InternalRow.fromSeq(value :: Nil))
+ valueConverter.eval(rowWrapper(value))
--- End diff --
Can you also change lines 1299 & 1304?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
