Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2973#discussion_r19498469
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SchemaRDD.scala ---
@@ -428,9 +397,10 @@ class SchemaRDD(
*/
private[sql] def collectToPython: JList[Array[Byte]] = {
val rowSchema =
StructType.fromAttributes(this.queryExecution.analyzed.output)
+ val fields = rowSchema.fields.map(_.dataType)
--- End diff --
Nit/existing: I'd avoid creating attributes which is actually pretty
expensive due to an `AtomicLong` and use the public API for `schema`. I think
instead of these two lines you can just do the following here and above.
```scala
val fieldTypes = schema.fields.map(_.dataType)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]