Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/21106
  
    I tried to unify this class with `UnsafeProjectionCreator`. So there is no 
more `UnsafeProjectionCreator` trait.
    
    Without the trait `UnsafeProjectionCreator`, one problem is we can't easily 
test both against `UnsafeProjection` and `InterpretedUnsafeProjection` objects 
with the same interface of `UnsafeProjectionCreator` (e.g., 
`UnsafeRowConverterSuite`).
    
    For test, I think we still need to test codegen and interpreted unsafe 
projection implementations individually as `UnsafeRowConverterSuite` does.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to