Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21141#discussion_r184250774
  
    --- Diff: python/pyspark/sql/tests.py ---
    @@ -3021,6 +3021,17 @@ def test_sort_with_nulls_order(self):
     
     class HiveSparkSubmitTests(SparkSubmitTests):
     
    +    @classmethod
    +    def setUpClass(cls):
    +        import glob
    +        from pyspark.find_spark_home import _find_spark_home
    +
    +        SPARK_HOME = _find_spark_home()
    +        filename_pattern = ("sql/hive/target/spark-hive_*-sources.jar")
    +        if not glob.glob(os.path.join(SPARK_HOME, filename_pattern)):
    +            raise unittest.SkipTest(
    --- End diff --
    
    I think we should see if @holdenk likes this or not too while we are here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to