Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21021#discussion_r184262552
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
 ---
    @@ -300,6 +333,49 @@ case class Reverse(child: Expression) extends 
UnaryExpression with ImplicitCastI
       override def prettyName: String = "reverse"
     }
     
    +/**
    + * Sorts the input array in ascending order according to the natural 
ordering of
    + * the array elements and returns it.
    + */
    +// scalastyle:off line.size.limit
    +@ExpressionDescription(
    +  usage = """
    +    _FUNC_(array) - Sorts the input array in ascending order. The elements 
of the input array must
    +      be orderable. Null elements will be placed at the end of the 
returned array.
    +  """,
    +  examples = """
    +    Examples:
    +      > SELECT _FUNC_(array('b', 'd', null, 'c', 'a'));
    +       ["a","b","c","d",null]
    +  """,
    +  since = "2.4.0")
    +// scalastyle:on line.size.limit
    +case class ArraySort(child: Expression) extends UnaryExpression with 
ArraySortUtil {
    +
    +  override def dataType: DataType = child.dataType
    +  override def inputTypes: Seq[AbstractDataType] = Seq(ArrayType)
    +
    +  override def arrayExpression: Expression = child
    +  override def nullOrder: Int = NullOrder.Least
    --- End diff --
    
    `nullOrder: NullOrder`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to