Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2753#discussion_r19499666
  
    --- Diff: 
core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala ---
    @@ -0,0 +1,76 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.network.netty
    +
    +import java.nio.ByteBuffer
    +
    +import org.apache.spark.Logging
    +import org.apache.spark.network.BlockDataManager
    +import org.apache.spark.serializer.Serializer
    +import org.apache.spark.network.buffer.{NioManagedBuffer, ManagedBuffer}
    +import org.apache.spark.network.client.{TransportClient, 
RpcResponseCallback}
    +import org.apache.spark.network.server.{DefaultStreamManager, RpcHandler}
    +import org.apache.spark.storage.{StorageLevel, BlockId}
    +
    +import scala.collection.JavaConversions._
    +
    +object NettyMessages {
    +
    +  /** Request to read a set of blocks. Returns [[ShuffleStreamHandle]] to 
identify the stream. */
    +  case class OpenBlocks(blockIds: Seq[BlockId])
    +
    +  /** Request to upload a block with a certain StorageLevel. Returns 
nothing (empty byte array). */
    +  case class UploadBlock(blockId: BlockId, blockData: Array[Byte], level: 
StorageLevel)
    +
    +  /** Identifier for a fixed number of chunks to read from a stream 
created by [[OpenBlocks]]. */
    +  case class ShuffleStreamHandle(streamId: Long, numChunks: Int)
    +}
    +
    +/**
    + * Serves requests to open blocks by simply registering one chunk per 
block requested.
    + */
    +class NettyBlockRpcServer(
    +    serializer: Serializer,
    +    streamManager: DefaultStreamManager,
    +    blockManager: BlockDataManager)
    +  extends RpcHandler with Logging {
    +
    +  import NettyMessages._
    +
    +  override def receive(
    +      client: TransportClient,
    +      messageBytes: Array[Byte],
    +      responseContext: RpcResponseCallback): Unit = {
    +    val ser = serializer.newInstance()
    +    val message = ser.deserialize[AnyRef](ByteBuffer.wrap(messageBytes))
    --- End diff --
    
    ah yes. nvm. the first part still stands though :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to