Github user mn-mikke commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21073#discussion_r184452750
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
 ---
    @@ -56,6 +58,28 @@ class CollectionExpressionsSuite extends SparkFunSuite 
with ExpressionEvalHelper
         checkEvaluation(MapValues(m2), null)
       }
     
    +  test("Map Concat") {
    --- End diff --
    
    Please add more test cases with `null` values.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to