Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21143#discussion_r184600589
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
---
@@ -56,7 +56,7 @@ case class DataSourceV2Relation(
lazy val (
--- End diff --
uh... Then, we should mention it in the comment too. For example,
```
// afterScanFilters: predicates that need to be evaluated after the scan.
// pushedFilters: predicates that will be pushed down and only evaluated in
the underlying data sources.
// Note: afterScanFilters and pushedFilters can overlap. For example, the
parquet row group filter
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
